Fix errors in t.Cleanup not being printed #1136
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a known issue that using `t.FailNow()` in deferred functions
can result in the error not being printed:
golang/go#29207
`t.FailNow` is also called by the `require` package, so using that in
deferred functions, including `t.Cleanup` functions, can result in the
error not being printed.
I can consistently reproduce that issue when the test is run in parallel
and also has subtests which are run in parallel. Minimal reproducer:
package main
import (
"testing"
"github.com/stretchr/testify/require"
)
func Test(t *testing.T) {
t.Parallel()
t.Cleanup(func() { require.Fail(t, "This error is never printed") })
t.Run("subtest", func(t *testing.T) { t.Parallel() })
}
Using non-fatal errors instead fixes the issue.
adombeck
force-pushed
the
fix-no-error-messages-in-test-cleanup
branch
from
3aabb97 to
a9e242f
Compare
3v1n0
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a known issue that using
t.FailNow()in deferred functions can result in the error not being printed.t.FailNowis also called by therequirepackage, so using that in deferred functions, includingt.Cleanupfunctions, can result in the error not being printed.I can consistently reproduce that issue when the test is run in parallel and also has subtests which are run in parallel. Minimal reproducer:
Using non-fatal errors instead fixes the issue.