-
Notifications
You must be signed in to change notification settings - Fork 30
Address current rust architecture.mk file #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
- Coverage 87.67% 87.60% -0.07%
==========================================
Files 90 90
Lines 6222 6222
Branches 111 111
==========================================
- Hits 5455 5451 -4
- Misses 711 715 +4
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The file has been moved from the rustc subdirectory to a per version. The generic rustc subdirectory location does not exist anymore since 24.10. 24.04 already has both locations for 1.85. Move it to point to the location compatible with 24.04+, but we need to have a better agnostic-way in the long term.
ccc9c1e to
9489fb0
Compare
I can confirm that at least on 25.10, I'm trying to understand why that didn't cause any build failures before. How did you discover the issue? Did you see it cause a build failure? Also trying to understand why on this branch all Debian package builds fail with: |
I now see this message from you on mattermost which I think already answers my question:
|
Maybe we should add a CI job which builds the source package to catch issues like that? |
|
We do already build the source package in CI: https://github.com/ubuntu/authd/actions/runs/20063065362/job/57544586787#step:3:2752 Why didn't the build fail there? This is getting more and more confusing 😵💫 |
The file has been moved from the rustc subdirectory to a per version.
The generic rustc subdirectory location does not exist anymore since24.10.
24.04 already has both locations for 1.85.
Move it to point to the location compatible with 24.04+, but we need to have a better agnostic-way in the long term.