Skip to content

Conversation

@adombeck
Copy link
Contributor

@adombeck adombeck commented Dec 17, 2025

Fix issues found by licenserecon.

UDENG-8725

As indicated by licenserecon aka lrc
@adombeck adombeck force-pushed the fix-debian-copyright branch from 2d02425 to 02ae33a Compare December 17, 2025 12:09
@adombeck
Copy link
Contributor Author

@3v1n0 lrc lists these issues in files authored by you (and only you AFAICT):

LGPL-3           | LGPL-3+           pam/go-exec/module.c
LGPL-3           | GPL-3+            pam/internal/gdm/extensions/gdm-custom-json-pam-extension.h

Did you deviate on purpose from the LGPL-3 which we use for our other files? Why?

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.64%. Comparing base (6ff09d2) to head (02ae33a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files          90       90           
  Lines        6222     6222           
  Branches      111      111           
=======================================
  Hits         5453     5453           
  Misses        713      713           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adombeck adombeck requested a review from 3v1n0 December 18, 2025 13:00
@3v1n0
Copy link
Collaborator

3v1n0 commented Dec 18, 2025

@3v1n0 lrc lists these issues in files authored by you (and only you AFAICT):

LGPL-3           | LGPL-3+           pam/go-exec/module.c

Mh, IIRC we generally use (L)GPL-3+ on Canonical stuff, but I'm fine to stick with 3 if it makes things more consistent with the project, not really a big deal ATM.

LGPL-3           | GPL-3+            pam/internal/gdm/extensions/gdm-custom-json-pam-extension.h

This comes from upstream, so sticking with GPL-3+ there.

@adombeck
Copy link
Contributor Author

Mh, IIRC we generally use (L)GPL-3+ on Canonical stuff, but I'm fine to stick with 3 if it makes things more consistent with the project, not really a big deal ATM.

Can we just remove the copyright notice from pam/go-exec/module.c to make it default to the ones from the repo?

This comes from upstream, so sticking with GPL-3+ there.

Who is upstream for pam/internal/gdm/extensions/gdm-custom-json-pam-extension.h? I don't see it mentioned anywhere in the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants