Ensured TMPDIR can now be overriden and is always valid. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm too! |
Contributor
|
Thanks for the working and sorry for the delay reviewing the change. Do we really still need that override? We removed it from the firefox snap the rational is
Is thunderbird sharing that default? If so should we do the same as firefox and just remove that script? |
|
Please let's get rid of that stupid thunderbird.tmp directory in ~/Downloads.. |
Author
|
@seb128 I'm also coming back this after a while. I deleted the file entirely. Can you merge? |
nteodosio
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves TMPDIR handling by ensuring:
~/Downloads/thunderbird.tmponly if it is unset or invalid./thunderbird.tmpis always appended to a valid directoryWhy
Previously, TMPDIR was overridden without minding user preference.
Linked Issue
Fixes #3