Add mig.shared.filemarks function test coverage #387
Conversation
jonasbardino
added
the
test-only
jonasbardino
force-pushed
the
add/mig-shared-filemarks-unit-tests
branch
from
7708fdc to
cbfb08d
Compare
…from the other unit tests.
disabled when run as privileged user like in our doker CI because basic ACLs are not fully enforced in that case.
jonasbardino
force-pushed
the
add/mig-shared-filemarks-unit-tests
branch
from
cbfb08d to
7d1d88e
Compare
| reset_result = reset_filemark(self.configuration, self.marks_base, | ||
| [TEST_MARKS_FILE], delete=True) | ||
| self.assertTrue(reset_result) | ||
| retrieved = get_filemark(self.configuration, self.marks_base, |
There was a problem hiding this comment.
It's not entirely clear which parts of this are arranging the test "situation" and which part is act.
albu-diku
left a comment
albu-diku
left a comment
There was a problem hiding this comment.
This test is relatively strightforward. I have noted that in at least one of the tests it isn't clear which of the operations correspnding to arranging the test cirsumstances and what is the operation that is actually being checked (act), which could use some clarification.
This also has the test name and docstring duplication, as mentioned #390 (comment). It affect that pull request much more than this one, and ideally we would address that before it goes in-tree. It looks like the docstrings in this file contain a more direct description of what is being tested.
Basic
mig/shared/filemarks.pyfunction test coverage reusing the overall structure from the other unit tests.