Skip to content

Conversation

@kellemNegasi
Copy link
Contributor

No description provided.

@kellemNegasi kellemNegasi reopened this Jan 27, 2025
@kellemNegasi kellemNegasi marked this pull request as ready for review January 27, 2025 13:06
Copy link
Contributor

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please do two simple changes in this PR:

  1. Update go version in go.mod to 1.19
  2. In go.yml change go: [ '1.22', '1.21', '1.20', '1.19', '1.18' ] to go: [ '1.23','1.22', '1.21', '1.20', '1.19']
    Both changes are because we updated minimal supported version to 1.19 for unipdf.

Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@anovik anovik merged commit 1a77cba into unidoc:master Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants