Skip to content

Conversation

@kellemNegasi
Copy link
Contributor

@kellemNegasi kellemNegasi commented Feb 26, 2025

This PR removes the mention of Offline License and Perpetual License from the example repo.
I used simple search to find these mentions.
https://unidoc.atlassian.net/browse/US-924

@kellemNegasi kellemNegasi marked this pull request as ready for review February 26, 2025 11:09
Copy link
Contributor

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about offlline licenses, are we removing them, too? Need to double check with Roman

Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely just only need to remove the "perpetual" word? like instead of "Offline Perpetual License Key" it will be "Offline License Key"

@anovik
Copy link
Contributor

anovik commented Feb 26, 2025

Likely just only need to remove the "perpetual" word? like instead of "Offline Perpetual License Key" it will be "Offline License Key"

Yeah, that's what I understand, too, so we will have subscriptions instead of perpetual. But having offline is important for enterprises

@sampila
Copy link
Contributor

sampila commented Feb 26, 2025

Likely just only need to remove the "perpetual" word? like instead of "Offline Perpetual License Key" it will be "Offline License Key"

Yeah, that's what I understand, too, so we will have subscriptions instead of perpetual. But having offline is important for enterprises

Yes, we do still had the offline license

@ipod4g
Copy link

ipod4g commented Feb 26, 2025

@kellemNegasi yes, you only need to remove the word "perpetual"
We will use "offline license"

@kellemNegasi
Copy link
Contributor Author

@kellemNegasi yes, you only need to remove the word "perpetual" We will use "offline license"

I got it. I will update this

@kellemNegasi kellemNegasi force-pushed the US-924-remove-perpetual-license branch from 286d09c to 3d2ca47 Compare February 26, 2025 16:26
@kellemNegasi kellemNegasi changed the title [US-924] Remove Mentions of Offline/Perpetual License [US-924] Remove Mentions of Perpetual License Feb 26, 2025
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@anovik anovik merged commit f81a2d3 into unidoc:master Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants