[US-897] Update grayscale example #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ace
approved these changes
Mar 21, 2025
anovik
approved these changes
Mar 21, 2025
Contributor
anovik
left a comment
anovik
left a comment
There was a problem hiding this comment.
Looks good. But this example itself is getting crazy, I hope we can move these grayscale functions into UniPDF soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
advanced/pdf_grayscale_transform.goincludes changes to improve the handling of image Smask and shading function bounds during the grayscale transformation of PDF content. The most important changes include adding support for image Smask and ensuring the shading function bounds are retained even if they are empty.Enhancements to grayscale transformation:
transformContentStreamToGrayscale: Added support to retain the image Smask if it exists.convertShadingToGray: Ensured that the shading function bounds are updated and retained, even if they are an empty array.