Skip to content

[US-1183] OCR service code examples #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anovik merged 7 commits into from
Nov 20, 2025
Merged

[US-1183] OCR service code examples #295

anovik merged 7 commits into from
Nov 20, 2025

Conversation

@3ace
Copy link
Contributor

@3ace 3ace commented Nov 20, 2025

No description provided.

@3ace 3ace requested review from anovik and sampila November 20, 2025 09:57
sampila
sampila approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
looks good to me

@anovik
Copy link
Contributor

anovik commented Nov 20, 2025

@sampila @3ace what about snyk failure? should it be fixed?

@3ace
Copy link
Contributor Author

3ace commented Nov 20, 2025 •
edited
Loading

@anovik @sampila that was triggered by the newly added 3rd party library for image manipulation and no fix yet so far. Let me replace it with other library.

@anovik
Copy link
Contributor

anovik commented Nov 20, 2025 •
edited
Loading

@anovik @sampila that was triggered by the newly added 3rd party library for image manipulation and no fix yet so far. Let me replace it with other library.

ok, good. Just I don't see any result from snyk that's why I am asking.

Also it is weird that merging is not blocked in this repo in case tests are failing.

@sampila
Copy link
Contributor

sampila commented Nov 20, 2025

@anovik @sampila that was triggered by the newly added 3rd party library for image manipulation and no fix yet so far. Let me replace it with other library.

ok, good. Just I don't see any result from snyk that's why I am asking.

Also it is weird that merging is not blocked in this repo in case tests are failing.

Yes, pretty strange snyk not blocking it

@3ace
Copy link
Contributor Author

3ace commented Nov 20, 2025

@anovik @sampila the library has been replaced in the latest commit.

@anovik anovik merged commit b684a75 into unidoc:master Nov 20, 2025
4 checks passed
@3ace 3ace deleted the us-1183-ocr-code-examples branch November 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anovik anovik anovik approved these changes

@sampila sampila sampila approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@3ace @anovik @sampila