[TM-2768] add site polygon bulk status update #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roguenet
reviewed
Dec 23, 2025
| @IsOptional() | ||
| @IsString() | ||
| @ApiProperty({ description: "Comment for the status update", required: false, type: String }) | ||
| comment: string | null = null; |
Collaborator
There was a problem hiding this comment.
For required: false, this should be comment?: string. If you really want to explicitly accept null, the ApiProperty should have nullable: true.
| @ApiOperation({ | ||
| operationId: "updateSitePolygonStatus", | ||
| summary: "Update the status of a site polygon", | ||
| description: "Update the status of a site polygon" |
Collaborator
There was a problem hiding this comment.
These descriptions make it sound like this endpoint operates on a single polygon.
| @JsonApiResponse({ data: SitePolygonLightDto, hasMany: true }) | ||
| @ExceptionResponse(UnauthorizedException, { description: "Authentication failed." }) | ||
| @ExceptionResponse(BadRequestException, { description: "Invalid request data." }) | ||
| @ExceptionResponse(NotFoundException, { description: "Site polygon not found." }) |
Collaborator
There was a problem hiding this comment.
This should also be something more like "At least one of the site polygons was not found".
| const userId = this.policyService.userId; | ||
| if (userId == null) { | ||
| throw new UnauthorizedException("User must be authenticated"); | ||
| } |
Collaborator
There was a problem hiding this comment.
For a normal endpoint (one that doesn't opt out of auth), the user id is guaranteed to be non null, so instead of this check, you can do:
const userId = this.policyService.userId as number;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Link