[TM-2778] Refactor DelayedJobsController to use 'id' instead of 'uuid… #472
Conversation
…' for job identifiers in DTOs and controller logic
| @ApiProperty({ format: "uuid", description: "UUID of the job", example: "uuid-1" }) | ||
| uuid: string; | ||
| @ApiProperty({ format: "uuid", description: "UUID of the job", example: "550e8400-e29b-41d4-a716-446655440000" }) | ||
| id: string; |
There was a problem hiding this comment.
Does the data will be uuid or id ?
In the example it says that it will be uuid, then there is an inconsistency in the name as it is id.
I think the fix should be in other part in order to keep the correct matching between the data (uuid) and the naming of it.
I mean if UUID is the data, then the name should be UUID too.
There was a problem hiding this comment.
The use of id is correct according to the JSON API. The format: uuid indicates the value format, not the field name.
Other DTOs in the project already use id with UUID values.
SitePolygonUpdate (line 42)
The frontend already sends id in the payload`.
In any case, I can try using UUIDs, but I think that would be a more complex solution for formatting it.
Task Link