#470 Change default find highlight color #481
Conversation
nangtrongvuon
left a comment
nangtrongvuon
left a comment
There was a problem hiding this comment.
Thanks for this! Overall looks good. but you shouldn't have the issue link as the commit message. Instead, describe what you did, and then put the link in the commit message body instead.
|
|
||
| let find_highlight: NSColor? = NSColor(jsonRgbaColor: json["find_highlight"] as? [String: Any] ?? [:]) | ||
| // Use default find highlight color instead of theme's find_highlight value | ||
| let find_highlight: NSColor? = Theme.defaultFindHighlightColor |
There was a problem hiding this comment.
I think if the theme specifies a color for find highlights, then it's ok to use that color instead of forcing the default yellow.
There was a problem hiding this comment.
Sure, I'm also bit not clear on expected behavior. I will wait for @cmyr's clarification #470 (comment)
Issue: xi-editor#470 Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor) Fix: * Theme has new static variable representing default find highlight color * Other find highlight colors are generated from the hue of default find highlight color * Find highlight color specified by xi-editor on theme_changed event is ignored
mohanio
force-pushed
the
470-set-default-find-highlight-color-to-system-default
branch
from
3ad5d49 to
df6d765
Compare
Updated the commit subject and message. |
2 participants
Summary
Issue:
#470
Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor)
Fix:
Related Issues
closes #470
Checklist
Example:
Review Checklist