Skip to content

fix when otherserial is null #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rallisf1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix when otherserial is null #57

rallisf1 wants to merge 2 commits into from

Conversation

@rallisf1
Copy link

@rallisf1 rallisf1 commented Nov 29, 2023

poorly fixes #56

@yllen
Copy link
Owner

yllen commented Jul 16, 2024

I never use your system, i use
Toolbox::stripTags($data["otherserial"] ?? "")
Burtyour PR is correct
I think you must also do the same change for serial

@rallisf1
Copy link
Author

rallisf1 commented Jul 16, 2024

Sure, done!

@RomainLvr RomainLvr mentioned this pull request Jan 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot print Changes with items

2 participants

@rallisf1 @yllen