Skip to content

chore: update taro&react version #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
MuxinFeng wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

chore: update taro&react version #73

MuxinFeng wants to merge 1 commit into from

Conversation

@MuxinFeng
Copy link
Contributor

@MuxinFeng MuxinFeng commented Jul 3, 2023

  1. 将 react 版本降到业务项目中的版本（避免出现多 react 实例的情况）
  2. 将 taro 相关版本升到最新（解决了尺寸转换等问题）

@SeaHaiWorld
Copy link
Collaborator

SeaHaiWorld commented Jul 3, 2023

可以先给这个版本范围看能不能解决，这个问题是因为组件库和demo依赖耦合，打包生产后package.json里还带了demo小程序依赖。后面替换pnpm包管理后用workspace会将的依赖拆开，组件库包引用后面不会安装自己的react和taro版本

@MuxinFeng
Copy link
Contributor Author

MuxinFeng commented Jul 3, 2023 •
edited
Loading

目前这套依赖没啥问题了，后面用了 pnpm 可以再换回来，现在这么做是因为在实际开发里调试太麻烦了。

wuxiuran
wuxiuran approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@wuxiuran wuxiuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MuxinFeng MuxinFeng marked this pull request as draft July 4, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuxiuran wuxiuran wuxiuran approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MuxinFeng @SeaHaiWorld @wuxiuran